feat: expand platform support in pixi and CI/CD workflow #91
Conversation
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/workflows/ci-cd.yml (1)
Line range hint
186-257: Consider enabling TestPyPI deployment pipelineThe commented-out sections for TestPyPI deployment and installation testing provide a valuable safety net for verifying releases before production deployment. This is especially important with the expanded platform support to catch potential platform-specific issues early.
Would you like me to help set up a separate workflow file for TestPyPI deployments that can be manually triggered?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pixi.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
.github/workflows/ci-cd.yml(1 hunks)pyproject.toml(1 hunks)
🔇 Additional comments (3)
pyproject.toml (1)
34-34: LGTM! Platform expansion aligns with CI workflow changes
The addition of "osx-64" and "win-64" platforms matches the expanded CI testing matrix that now includes Windows support.
.github/workflows/ci-cd.yml (2)
19-19: LGTM! OS matrix expansion matches platform support
The addition of windows-latest to the test matrix properly aligns with the expanded platform support in pyproject.toml.
Line range hint 14-14: Consider increasing timeout for Windows builds
The current 15-minute timeout might be insufficient for Windows builds, which typically take longer than Linux/macOS. Consider increasing the timeout specifically for Windows runs.
Let's analyze historical build times:
Consider using job-specific timeouts:
Unit-Tests:
runs-on: ${{ matrix.os }}
- timeout-minutes: 15 # Consider increasing timeout
+ timeout-minutes: ${{ matrix.os == 'windows-latest' && 30 || 15 }}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 49.04% 42.16% -6.88%
==========================================
Files 25 28 +3
Lines 991 1174 +183
==========================================
+ Hits 486 495 +9
- Misses 505 679 +174 ☔ View full report in Codecov by Sentry. |
This PR adds the windows platform and older mac platform to the pixi configuration so developers with those machines can be assured that they can contribute to this project without running into dependency issues
Summary by CodeRabbit
New Features
Bug Fixes